[HUDI-3825] Fixing non-partitioned table Partition Records persistence in MT #5259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 7, 2022 18:05
…_all_partitions__" record
alexeykudinkin
commented
Apr 8, 2022
| if (partitionTypes.contains(MetadataPartitionType.FILES)) { | ||
| // Record which saves the list of all partitions | ||
| HoodieRecord allPartitionRecord = HoodieMetadataPayload.createPartitionListRecord(partitions); | ||
| if (partitions.isEmpty()) { |
Contributor
Author
There was a problem hiding this comment.
This is just pure duplication
| HoodieTableMetadataUtil.getPartition(partitionInfo.getRelativePath()), Option.of(validFileNameToSizeMap), Option.empty()); | ||
| }); | ||
| filesPartitionRecords = filesPartitionRecords.union(fileListRecords); | ||
| if (partitionInfoList.isEmpty()) { |
Contributor
Author
There was a problem hiding this comment.
Just inverted conditional to simplify control flow
Collaborator
xushiyan
pushed a commit
that referenced
this pull request
Apr 14, 2022
…e in MT (#5259) * Filter out empty string (for non-partitioned table) being added to "__all_partitions__" record * Instead of filtering, transform empty partition-id to `NON_PARTITIONED_NAME` * Cleaned up `HoodieBackedTableMetadataWriter` * Make sure REPLACE_COMMITS are handled as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Fixing non-partitioned table Partition Records persistence in MT.
Right now for non-partitioned table both "" (empty) and "." will be persisted as corresponding partitions, which is incorrect. Instead we make sure that we always map factual partition path (empty) into a partition-id (".") before persisting it to MT.
Brief change log
Check out above
Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.