[HUDI-3454] Fix partition name in all code paths for LogRecordScanner #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudi-cli/src/main/java/org/apache/hudi/cli/commands/HoodieLogFileCommand.java
Show resolved
Hide resolved
...udi-examples-flink/src/test/java/org/apache/hudi/examples/quickstart/TestQuickstartData.java
Outdated
Show resolved
Hide resolved
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/FormatUtils.java
Outdated
Show resolved
Hide resolved
alexeykudinkin
approved these changes
Apr 8, 2022
Collaborator
danny0405
reviewed
Apr 8, 2022
| .withDiskMapType(diskMapType) | ||
| .withBitCaskDiskMapCompressionEnabled(isCompressionEnabled) | ||
| .withPartition(getRelativePartitionPath(new Path(basePath), new Path(logFilePaths.get(0)).getParent())) | ||
| .build(); |
Contributor
There was a problem hiding this comment.
Can we inline the fix into the HoodieMergedLogRecordScanner so that there is no need to change these classes ?
Contributor
|
Left one comment and see if we can put some improvement here. |
xushiyan
pushed a commit
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
HUDI-3454
There were some paths where we did not init partition while building log record scanner. Fixed all such code paths.
Brief change log
FSUtils#getRelativePartitionPath(basePath, logFilePath.getParent)to get the partition.Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.