-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-3781] fix spark delete sql can not delete record #5215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...e/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/DeleteHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
XuQianJin-Stars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e4560a3 to
79f41c8
Compare
79f41c8 to
0f2fe34
Compare
|
fix conflicts |
|
other command has the same question, I open a issue to discuss #5248 |
|
hi @KnightChess Retrigger the CI of the github action. |
|
@KnightChess @XuQianJin-Stars how about forbidden set hoodie.datasource.write.operation when we create hudi table. |
|
@XuQianJin-Stars how to retrigger it? |
@xiarixiaoyao in #5248 , I think check is better |
reopen this pr or commit pr comments. |
|
@KnightChess thanks for your contribution. |
What is the purpose of the pull request
fix can not delete record by use spark sql. operation.key must be "delete"
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.