Skip to content

Conversation

@KnightChess
Copy link
Contributor

What is the purpose of the pull request

fix can not delete record by use spark sql. operation.key must be "delete"

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Copy link
Contributor

@XuQianJin-Stars XuQianJin-Stars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KnightChess
Copy link
Contributor Author

fix conflicts

@hudi-bot
Copy link
Collaborator

hudi-bot commented Apr 6, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@KnightChess
Copy link
Contributor Author

other command has the same question, I open a issue to discuss #5248

@xiarixiaoyao xiarixiaoyao self-assigned this Apr 7, 2022
@XuQianJin-Stars
Copy link
Contributor

hi @KnightChess Retrigger the CI of the github action.

@xiarixiaoyao
Copy link
Contributor

@KnightChess @XuQianJin-Stars how about forbidden set hoodie.datasource.write.operation when we create hudi table.
maybe we can do some check when we create table, or ignore this paramter and print some log for it.

@KnightChess
Copy link
Contributor Author

@XuQianJin-Stars how to retrigger it?

@KnightChess
Copy link
Contributor Author

@KnightChess @XuQianJin-Stars how about forbidden set hoodie.datasource.write.operation when we create hudi table. maybe we can do some check when we create table, or ignore this paramter and print some log for it.

@xiarixiaoyao in #5248 , I think check is better

@XuQianJin-Stars
Copy link
Contributor

@XuQianJin-Stars how to retrigger it?

reopen this pr or commit pr comments.

@KnightChess KnightChess closed this Apr 8, 2022
@KnightChess KnightChess reopened this Apr 8, 2022
@xiarixiaoyao
Copy link
Contributor

@KnightChess thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants