[HUDI-3724] Fixing closure of ParquetReader #5141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
changed the title
leesf
reviewed
Mar 27, 2022
hudi-common/src/main/java/org/apache/hudi/common/util/ParquetReaderIterator.java
Outdated
Show resolved
Hide resolved
leesf
reviewed
Mar 27, 2022
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieParquetReader.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@leesf : addressed your comments. Feel free to merge if looks good. thanks |
nsivabalan
force-pushed
the
morStackOverFlow
branch
from
ac001c3 to
c1cdbc2
Compare
Collaborator
leesf
approved these changes
Mar 28, 2022
danny0405
reviewed
Mar 28, 2022
| parquetReader.apply(partitionedFile) | ||
| val iter = parquetReader.apply(partitionedFile) | ||
| if (iter.isInstanceOf[Closeable]) { | ||
| // register a callback to close parquetReader which will be executed on task completion. |
Contributor
There was a problem hiding this comment.
Did you mean AutoClosable ?
| private final Path path; | ||
| private final Configuration conf; | ||
| private final BaseFileUtils parquetUtils; | ||
| private List<ParquetReaderIterator> readerIterators = new ArrayList<>(); |
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala
Show resolved
Hide resolved
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
We were running integration tests against hudi and in recent times we are seeing "too many open files" and the spark long running COW tests fails. Looks like we don't close the parquet reader in couple of places. Fixing the closure in this patch.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.