[HUDI-3689] Fix glob path and hive sync in deltastreamer tests #5117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
the CI will fail. but if you can put screenshots showing which testcases become passing with this patch, would be great |
Minor checkstyle Some more removals of glob path
for CI failure in TestHoodieRealTimeRecordReader
xushiyan
approved these changes
Mar 24, 2022
codope
force-pushed
the
ci-fix-glob-hive
branch
from
13d5a7a to
2f7204b
Compare
codope
changed the title
Collaborator
| TestHelpers.assertRecordCount(1000, downstreamTableBasePath + "/*/*.parquet", sqlContext); | ||
| TestHelpers.assertDistanceCount(1000, downstreamTableBasePath + "/*/*.parquet", sqlContext); | ||
| TestHelpers.assertDistanceCountWithExactValue(1000, downstreamTableBasePath + "/*/*.parquet", sqlContext); | ||
| TestHelpers.assertRecordCount(1000, downstreamTableBasePath, sqlContext); |
Contributor
There was a problem hiding this comment.
@nsivabalan let's create a ticket to follow-up on globbing issue
| orcProps.setProperty("hoodie.embed.timeline.server", "false"); | ||
| orcProps.setProperty("hoodie.datasource.write.recordkey.field", "_row_key"); | ||
| orcProps.setProperty("hoodie.datasource.write.partitionpath.field", "not_there"); | ||
| orcProps.setProperty("hoodie.datasource.write.partitionpath.field", "partition_path"); |
Contributor
There was a problem hiding this comment.
@codope @nsivabalan aren't we changing the intent of the test here?
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…e#5117) * Remove glob pattern basePath from the deltastreamer tests. * [HUDI-3689] Fix file scheme config for CI failure in TestHoodieRealTimeRecordReader Co-authored-by: Raymond Xu <[email protected]>
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
…e#5117) * Remove glob pattern basePath from the deltastreamer tests. * [HUDI-3689] Fix file scheme config for CI failure in TestHoodieRealTimeRecordReader Co-authored-by: Raymond Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR fixes some of the deltastreamer tests in order to stabilize the CI
Brief change log
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.