[HUDI-3604] Adjust the order of timeline changes in rollbacks #5114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
force-pushed
the
HUDI-3604-metadata-table-with-rollbacks
branch
from
88594a9 to
fe2c05d
Compare
nsivabalan
reviewed
Mar 24, 2022
|
|
||
| // If publish the rollback to the timeline, we first write the rollback metadata | ||
| // to metadata table | ||
| if (!skipTimelinePublish) { |
Contributor
There was a problem hiding this comment.
we should see if we can make this more readable or nicer. I will approve it for now. but see if we can improve this sometime.
Contributor
Author
There was a problem hiding this comment.
Makes sense. I'll refactor this later on.
yihua
force-pushed
the
HUDI-3604-metadata-table-with-rollbacks
branch
from
fe2c05d to
77a160c
Compare
yihua
force-pushed
the
HUDI-3604-metadata-table-with-rollbacks
branch
from
77a160c to
5bc41f7
Compare
Collaborator
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Before this change, the sequence of changes in the rollback action are:
(1) Get the instant (C1) to roll back. If there is already a pending rollback (RB_C1) for the same instant (C1) in the active timeline, the same rollback instant (RB_C1) and the rollback plan are reused. Otherwise, schedule a new rollback instant.
(2) Transition C1 to inflight if completed.
(3) Delete data files written by C1.
(4) Delete instant files (C1) in the data table timeline.
(5) Commit changes from the rollback (RB_C1) to metadata table
(6) Transition the rollback instant (RB_C1) from inflight to complete on data table timeline.
By design, we should only change data table timeline after committing the changes to the metadata table. This PR changes the order of timeline changes as below, switching the order of (4) and (5) above:
(1) Get the instant (C1) to roll back. If there is already a pending rollback (RB_C1) for the same instant (C1) in the active timeline, the same rollback instant (RB_C1) and the rollback plan is reused. Otherwise, schedule a new rollback instant.
(2) Transition C1 to inflight if completed.
(3) Delete data files written by C1.
(4) Commit changes from the rollback (RB_C1) to metadata table
(5) Delete instant files (C1) in the data table timeline.
(6) Transition the rollback instant (RB_C1) from inflight to complete on data table timeline.
Brief change log
BaseRollbackActionExecutor, by first applying the rollback metadata to the metadata table, then deleting the instant files of the instant to rollback in the data table timeline, and finally transiting the inflight rollback to complete in the data table timeline.Verify this pull request
This pull request is already covered by existing tests around rollbacks.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.