[HUDI-3638] Make ZookeeperBasedLockProvider serializable #5112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
force-pushed
the
HUDI-3638-serializable-zk-lock
branch
from
453b745 to
f20c755
Compare
yihua
force-pushed
the
HUDI-3638-serializable-zk-lock
branch
from
f20c755 to
28b0906
Compare
nsivabalan
approved these changes
Mar 24, 2022
yihua
changed the title
Collaborator
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
Contributor
|
@yihua Thank you for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR makes ZookeeperBasedLockProvider serializable so that clean action does not complain about
Task not serializabledue to ZookeeperBasedLockProvider or CuratorFramework.Brief change log
As above.
Verify this pull request
This PR is verified by running deltastreamer continuous mode writing to a COW table, with async clustering and cleaner enabled, using ZooKeeper as the lock provider. Before this change, the job encounters
Task not serializableexception. After this change, the job proceeds without any issue.Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.