[HUDI-3684] Fixing NPE in ParquetUtils
#5102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykudinkin
force-pushed
the
ak/mtmod-idx-fix-2
branch
from
fdc8759 to
8311cb4
Compare
alexeykudinkin
changed the title
ParquetUtils
codope
approved these changes
Mar 23, 2022
| .stream().filter(Objects::nonNull).min(Comparator.naturalOrder()).orElse(null), | ||
| (Comparable) Arrays.asList(oldColumnRange.getMinValue(), newColumnRange.getMinValue()) | ||
| .stream().filter(Objects::nonNull).max(Comparator.naturalOrder()).orElse(null), | ||
| (Comparable) Stream.of(oldColumnRange.getMinValue(), newColumnRange.getMinValue()) |
Member
There was a problem hiding this comment.
Good catch! We should replace Arrays.asList by Stream if there are other such places.
Collaborator
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
* Make sure nulls are properly handled in `HoodieColumnRangeMetadata`
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
* Make sure nulls are properly handled in `HoodieColumnRangeMetadata`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Addresses NPE in
ParquetUtilsnot handlingnullmin/max statisticsBrief change log
Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.