[HUDI-3539] Flink bucket index bucketID bootstrap optimization. #5093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Contributor
Author
|
@garyli1019 An improvement for HUDI-3315, please take a look. |
garyli1019
reviewed
Mar 22, 2022
Member
garyli1019
left a comment
garyli1019
left a comment
There was a problem hiding this comment.
LGTM, left a minor comment.
|
|
||
| if (bucketIndex.containsKey(partitionBucketId)) { | ||
| location = new HoodieRecordLocation("U", bucketIndex.get(partitionBucketId)); | ||
| if (incBucketIndex.contains(partitionBucketId)) { |
Member
There was a problem hiding this comment.
nice catch, a bug fixed here
...link-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/BucketStreamWriteFunction.java
Show resolved
Hide resolved
minihippo
force-pushed
the
flink-bucket-op
branch
from
1571926 to
48807f4
Compare
garyli1019
approved these changes
Mar 23, 2022
Member
|
@hudi-bot run azure |
1 similar comment
Member
|
@hudi-bot run azure |
Member
|
@minihippo would you resolve the conflict |
minihippo
force-pushed
the
flink-bucket-op
branch
from
84fbc2e to
7d10408
Compare
Member
|
@hudi-bot run azure |
danny0405
reviewed
Mar 28, 2022
|
|
||
| bootstrapIndexIfNeed(partition); | ||
| Map<Integer, String> bucketToFileIdMap = bucketIndex.get(partition); | ||
| final int bucketNum = BucketIdentifier.getBucketId(hoodieKey, indexKeyFields, this.bucketNum); |
Contributor
There was a problem hiding this comment.
.get(partition) -> computeIfAbsent(partition, p -> new HashMap<>())
Contributor
|
Thanks for the fix, i have fired a minor fix patch, can you apply it then, thanks ~ |
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…he#5093) * [HUDI-3539] Flink bucket index bucketID bootstrap optimization. Co-authored-by: gengxiaoyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Optimization for bootstrap when use flink bucket index. Load and cache the filegroups info of a partition which poccessing the records belong to instead of loading all partitions at first.
Brief change log
Verify this pull request
This pull request is already covered by existing tests.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.