[HUDI-3640] Set SimpleKeyGenerator as default in 2to3 table upgrade for Spark engine #5075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
force-pushed
the
HUDI-3640-2to3-key-gen
branch
from
c4ad59e to
fff3082
Compare
yihua
force-pushed
the
HUDI-3640-2to3-key-gen
branch
from
fff3082 to
bd25c00
Compare
nsivabalan
approved these changes
Mar 22, 2022
...hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/TwoToThreeUpgradeHandler.java
Show resolved
Hide resolved
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
By default, for Deltastreamer and Spark datasource, if the key generator class is not configured by the user, the
SimpleKeyGeneratoris used by default. However, the table upgrade from v2 to v3 still expects explicit key generator class config for Spark and fails if not set. This PR sets the key generator class toorg.apache.hudi.keygen.SimpleKeyGeneratorfor Spark client if it is not set in the write configs, so that the table upgrade can succeed without the following validation error.Brief change log
TwoToThreeUpgradeHandlerTestTwoToThreeUpgradeHandler(hudi-client-common) andTestUpgradeDowngrade(hudi-spark-client)Verify this pull request
This change adds tests in
TestTwoToThreeUpgradeHandler(hudi-client-common) andTestUpgradeDowngrade(hudi-spark-client) for spark client to verify the upgrade logic is expected.I also tested this PR by writing a MOR table with Hudi 0.9.0 deltastreamer without setting
hoodie.datasource.write.keygenerator.classfirst, and then using the build from this PR to continue writing the same table with the same configs. The ingestion can continue and the table upgrade is successful (before this change the table upgrade failed).Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.