[HUDI-3607] Support backend switch in HoodieFlinkStreamer #5032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxianghu
reviewed
Mar 15, 2022
hudi-flink/src/main/java/org/apache/hudi/util/FlinkStateBackendConverter.java
Outdated
Show resolved
Hide resolved
wangxianghu
requested changes
Mar 15, 2022
Contributor
wangxianghu
left a comment
wangxianghu
left a comment
There was a problem hiding this comment.
Hi @liufangqi, thanks for your contribution, this patch LGTM overall
left two minor comments you can consider
hudi-flink/src/main/java/org/apache/hudi/streamer/FlinkStreamerConfig.java
Outdated
Show resolved
Hide resolved
nsivabalan
added
engine:flink
1. change the msg
Contributor
Author
|
@wangxianghu THX for your review. I think it's a good advice for the description and the exception msg. Updated the code in the new commit. Could you help to review it again when you are free? |
Collaborator
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
* [HUDI-3607] Support backend switch in HoodieFlinkStreamer * [HUDI-3607] Support backend switch in HoodieFlinkStreamer 1. checkstyle fix * [HUDI-3607] Support backend switch in HoodieFlinkStreamer 1. change the msg
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
* [HUDI-3607] Support backend switch in HoodieFlinkStreamer * [HUDI-3607] Support backend switch in HoodieFlinkStreamer 1. checkstyle fix * [HUDI-3607] Support backend switch in HoodieFlinkStreamer 1. change the msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Now, HoodieFlinkStreamer utility only support one backend - FsStateBackend.
I think it's not flexible for the application configuration. Could we make backend configurable?
Moreover, for flink version 1.14, FsStateBackend is deprecated in favor of org.apache.flink.runtime.state.hashmap.HashMapStateBackend and org.apache.flink.runtime.state.storage.FileSystemCheckpointStorage.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.