Skip to content

Conversation

@XuQianJin-Stars
Copy link
Contributor

Tips

What is the purpose of the pull request

link: HUDI-3501

  1. create_savepoints
  2. show_savepoints
  3. delete_savepoints
  4. rollback_savepoints

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@wangxianghu wangxianghu self-assigned this Mar 13, 2022
Copy link
Contributor

@wangxianghu wangxianghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuQianJin-Stars thanks for your contribution
LGTM!

@wangxianghu wangxianghu merged commit 6c8224c into apache:master Mar 13, 2022
@Zouxxyy
Copy link
Contributor

Zouxxyy commented Oct 26, 2022

@XuQianJin-Stars Hi, create_savepoint and rollback_savepoint use different parameters, with one using commit_time and the other using instant_time, which I felt might confuse the user~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants