[HUDI-3593] Restore TypedProperties and flush checksum in table config #5013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Outdated
Show resolved
Hide resolved
nsivabalan
reviewed
Mar 10, 2022
codope
force-pushed
the
HUDI-3593-clustering-cme
branch
from
a2e2b2e to
f50fc26
Compare
boneanxs
reviewed
Mar 11, 2022
hudi-common/src/main/java/org/apache/hudi/common/config/OrderedProperties.java
Show resolved
Hide resolved
boneanxs
approved these changes
Mar 11, 2022
nsivabalan
approved these changes
Mar 11, 2022
hudi-common/src/main/java/org/apache/hudi/common/config/OrderedProperties.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/config/OrderedProperties.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Outdated
Show resolved
Hide resolved
Create new TypedProperties while performing clustering Add OrderedProperties and minor refactoring Add javadoc and remove getters from OrderedProperties
codope
force-pushed
the
HUDI-3593-clustering-cme
branch
from
f50fc26 to
5afecce
Compare
Collaborator
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
apache#5013) Create new TypedProperties while performing clustering Add OrderedProperties and minor refactoring Add javadoc and remove getters from OrderedProperties
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
apache#5013) Create new TypedProperties while performing clustering Add OrderedProperties and minor refactoring Add javadoc and remove getters from OrderedProperties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
TypedProperties#keysis not thread-safe. It was added in #4712 to ensure insertion order of properties is maintained. It was done in order to add a table checksum config in the end which would be used to validate thathoodie.propertiesis not written partially. However, TypedProperties not being thread-safe could result in ConcurrentModificationException as there are places in clustering where write config is passed to spark executor and it might happen that while one thread is trying to serialize it the other is trying to modify it. However, the solution to original problem need not depend on ordering. We can just add table checksum in the end and then while readinghoodie.propertiesjust ensure that prop exists.Brief change log
TypedProperties#keyshoodie.properties.Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.