Skip to content

Conversation

@JerryYue-M
Copy link
Contributor

…o adjust the number of parallelism

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan nsivabalan added priority:medium Moderate impact; usability gaps engine:flink Flink integration labels Mar 15, 2022
Copy link
Contributor

@wangxianghu wangxianghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JerryYue-M Thanks for your contribution
LGTM, only one typo from my side

.noDefaultValue()
.withDescription("Parallelism of tasks that do bucket assign, default is the parallelism of the execution environment");

public static final ConfigOption<Integer> HOODIE_ROECORD_MAP_TASKS = ConfigOptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ROECORD -> RECORD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangxianghu
thanks for review, i had fixed the problem what you pointed out
pls review again

@wangxianghu wangxianghu self-assigned this Mar 15, 2022
@wangxianghu
Copy link
Contributor

@hudi-bot run azure

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate a little why this is needed ? Usually the mapping should not be bottleneck and we try to avoid the explicit parallelism of the operator to reduce the data shuffle. The default parallelism would make the operator chain with the source.

@JerryYue-M
Copy link
Contributor Author

JerryYue-M commented Mar 16, 2022

@danny0405 ,the real problem is this operator just use the the default parallelism of job instead of source parallelism. in some case, we will set parallelism for each operator include source operator. so this function can't chain the source operator, just because it always use the job default parallelism when source don't use the default parallelism of job.
if source don't use the default parallelism of job, so do this.

@wangxianghu
Copy link
Contributor

closing since a new one created #5049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine:flink Flink integration priority:medium Moderate impact; usability gaps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants