-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-3598] Row Data to Hoodie Record Operator should support users t… #5007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o adjust the number of parallelism
wangxianghu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JerryYue-M Thanks for your contribution
LGTM, only one typo from my side
| .noDefaultValue() | ||
| .withDescription("Parallelism of tasks that do bucket assign, default is the parallelism of the execution environment"); | ||
|
|
||
| public static final ConfigOption<Integer> HOODIE_ROECORD_MAP_TASKS = ConfigOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo ROECORD -> RECORD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangxianghu
thanks for review, i had fixed the problem what you pointed out
pls review again
|
@hudi-bot run azure |
danny0405
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate a little why this is needed ? Usually the mapping should not be bottleneck and we try to avoid the explicit parallelism of the operator to reduce the data shuffle. The default parallelism would make the operator chain with the source.
|
@danny0405 ,the real problem is this operator just use the the default parallelism of job instead of source parallelism. in some case, we will set parallelism for each operator include source operator. so this function can't chain the source operator, just because it always use the job default parallelism when source don't use the default parallelism of job. |
|
closing since a new one created #5049 |
…o adjust the number of parallelism
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.