[HUDI-3595] Fixing NULL schema provider for empty batch #5002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
when Deltastreamer consumes an empty batch, but checkpoint moved ahead, hudi injects NullSchemaProvider as part of consumed InputBatch. Which returns null schema (Schema.create(Schema.Type.NULL)) schema when asked for source or target schema. So, this gets serialized into commit metadata and later runs into issues when table schema is fetched.
Fix: when serializing the schema to commit metadata, we avoid adding the entry if its null schema (Schema.create(Schema.Type.NULL)).
Ideally, we want to fix the schema provider returned as part of empty batch itself. But don't want to fix it right away as it could blow up somewhere else. So, created a ticket for later.
TableSchemaProvider is capable of walking back to previous commits to find the right schema and hence skipping to add schema should be fine.
Brief change log
Fixed serializing the avro schema to commit metadata to avoid adding the entry if its null schema (Schema.create(Schema.Type.NULL))
Verify this pull request
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.