[HUDI-3556] Re-use rollback instant for rolling back of clustering and compaction if rollback failed mid-way #4971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
added
status:triaged
yihua
reviewed
Mar 9, 2022
...nt/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
Show resolved
Hide resolved
…nt if previous attempt failed
…d compaction if rollback failed mid-way
nsivabalan
force-pushed
the
compactClusterReuseRollbackInstant
branch
from
74ace6c to
7367ebf
Compare
Collaborator
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…d compaction if rollback failed mid-way (apache#4971)
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
…d compaction if rollback failed mid-way (apache#4971)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
If clustering/compaction rollback failed mid-way, if rollback of a pending clustering/compaction is re-attempted, a new rollback instant will be generated. We would want to retry using the same rollback instant. Main motivation is that, the old failed rollback instant is never cleaned up. And so it could lead to liveness issues w/ metadata table.
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.