Skip to content

Conversation

@wangxianghu
Copy link
Contributor

…etting multi processors at once

Tips

What is the purpose of the pull request

Introduce ChainedJsonKafkaSourePostProcessor to support setting multi processors at once

Verify this pull request

This pull request is already covered by existing tests
org.apache.hudi.utilities.sources.TestJsonKafkaSourcePostProcessor#testChainedJsonKafkaSourcePostProcessor

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan nsivabalan added the priority:medium Moderate impact; usability gaps label Mar 7, 2022
@wangxianghu wangxianghu changed the title [HUDI-3569] Introduce ChainedJsonKafkaSourePostProcessor to support s… [HUDI-3569] Introduce ChainedJsonKafkaSourePostProcessor to support setting multi processors at one time Mar 8, 2022
@nsivabalan
Copy link
Contributor

Do we really see a need for chained post processor just for jsonKafkaSource. Unless or otherwise required, don't want to add them. if you know of valid use-case, let me know.

@wangxianghu
Copy link
Contributor Author

wangxianghu commented Mar 9, 2022

Do we really see a need for chained post processor just for jsonKafkaSource. Unless or otherwise required, don't want to add them. if you know of valid use-case, let me know.

@nsivabalan thanks for your review
There might be fewer usage scenarios compare to Transformer

But, in our companay, we use maxwell to subscribe binlog,so I add a MaxwellJsonKafkaPostprocessor to extract the data we need.

sometimes, there might be some data quality problems, for example, some not nullable fileds have null values, we have to fix it through processor,
sometimes, we also need to encode some fields for safety purpose, MaxwellJsonKafkaPostprocessor + user-defined encode processor could be a choice.

So I think somebody else who use maxwell may need this feature too

@wangxianghu
Copy link
Contributor Author

@hudi-bot run azure

1 similar comment
@wangxianghu
Copy link
Contributor Author

@hudi-bot run azure

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@wangxianghu
Copy link
Contributor Author

wangxianghu commented Mar 11, 2022

hi @nsivabalan can we add this processor ? it is very useful in scenarios with diversified data requirements.
In our comany, we have use this feature to add multiple processors to our pipeline:

  1. maxwell post processor : extract data from maxwell json string. this is a standard processor
  2. Encrypt post processor : Encrypt some fields for safety purpose
  3. flag post processor : this is quite a business related processor.

with ChainedJsonKafkaSourcePostProcessor we can make data processing more flexible, it makes up for the lack of expression ability of Transformer

@nsivabalan
Copy link
Contributor

sounds good 👍

@nsivabalan nsivabalan merged commit e8918b6 into apache:master Mar 11, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Moderate impact; usability gaps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants