[HUDI-3383] Sync column comments while syncing a hive table, especially using spark datasource api #4960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desc: Add a hive sync config(hoodie.datasource.hive_sync.sync_comment). This config defaults to false. While syncing data source to hudi, add column comments to source avro schema, and the sync_comment is true, syncing column comments to the hive table.
Contributor
Author
|
@nsivabalan |
Contributor
|
@hudi-bot run azure |
Contributor
Author
|
@xiarixiaoyao the CI report has been successful. pls help me review again when you are free. thank you very much. |
Contributor
|
@MrSleeping123 thanks， i will review it tomorrow |
xiarixiaoyao
approved these changes
Mar 7, 2022
Contributor
|
LGTM |
Contributor
|
@nsivabalan if you have free time， could you pls review again ， thanks |
Contributor
|
@MrSleeping123 thanks for your contribute， will merge it tomorrow. |
Contributor
Author
@xiarixiaoyao thank you very much. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
The pr is syncing source table column comments to a hive table with syncing hudi to hive when users add column comments to datasource schema.
Brief change log
(for example: using spark datasource)
StructType schema = new StructType().add("key", "string", false, "comment")sparkSession.createDataFrame(rdd, schema).write().format("org.apache.hudi").......option("hoodie.datasource.hive_sync.sync_comment","true").......save("/xxxx");Verify this pull request
Run TestHiveSyncTool#testUpdateTableComments and TestHiveSyncTool#testSyncWithCommentedSchema successfully.
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.