-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-3538] Support Compaction Command Based on Call Procedure Command for Spark SQL #4945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hudi-bot run azure |
1 similar comment
Contributor
Author
|
@hudi-bot run azure |
5 tasks
...ource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/Constants.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/CompactionHoodiePathCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/java/org/apache/spark/sql/hudi/command/procedures/ProcedureConstEnum.java
Outdated
Show resolved
Hide resolved
XuQianJin-Stars
approved these changes
Mar 26, 2022
Contributor
XuQianJin-Stars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...ark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/RunCompactionProcedure.scala
Show resolved
Hide resolved
Contributor
|
LGTM, just a minor comment. once addressed, we can merge it. |
xiarixiaoyao
approved these changes
Mar 28, 2022
Collaborator
Contributor
|
@huberylee Thank you for your contribution |
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…d for Spark SQL (apache#4945) * Support Compaction Command Based on Call Procedure Command for Spark SQL * Addressed review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Supporting compaction command for Spark SQL, so that we can manually trigger/show compaction by call procedure command:
Brief change log
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.