Skip to content

Conversation

@huberylee
Copy link
Contributor

@huberylee huberylee commented Mar 3, 2022

What is the purpose of the pull request

Supporting compaction command for Spark SQL, so that we can manually trigger/show compaction by call procedure command:

call run_compaction( 'schedule', 'test')
call run_compaction(op => 'schedule', table => 'test')
call run_compaction(op => 'schedule', path => './dataset/test')
...
call run_compaction('run', 'test')
call run_compaction(op => 'run', table => 'test')
call run_compaction(op => 'schedule', path => './dataset/test', timestamp => '20220314175600')
...

Brief change log

  • Add RunCompactionProcedure and ShowCompactionProcedure
  • Add test case in TestCallProcedure

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@huberylee
Copy link
Contributor Author

@hudi-bot run azure

1 similar comment
@huberylee
Copy link
Contributor Author

@hudi-bot run azure

Copy link
Contributor

@XuQianJin-Stars XuQianJin-Stars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiarixiaoyao
Copy link
Contributor

LGTM, just a minor comment. once addressed, we can merge it.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xiarixiaoyao
Copy link
Contributor

@huberylee Thank you for your contribution

@xiarixiaoyao xiarixiaoyao merged commit 1d0f4cc into apache:master Mar 28, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
…d for Spark SQL (apache#4945)

* Support Compaction Command Based on Call Procedure Command for Spark SQL

* Addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants