[HUDI-3544] Fixing "populate meta fields" update to metadata table #4941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
changed the title
codope
force-pushed
the
metadataUpdateConfigsAfterBootstrap
branch
from
9718564 to
91b3cb2
Compare
Collaborator
codope
approved these changes
Mar 3, 2022
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
LGTM! Just fixed a checkstyle violation.
Contributor
Author
|
thanks @codope for fixing it. |
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…pache#4941) * Fixing populateMeta fields update to metadata table * Fix checkstyle violations Co-authored-by: Sagar Sumit <[email protected]>
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
…pache#4941) * Fixing populateMeta fields update to metadata table * Fix checkstyle violations Co-authored-by: Sagar Sumit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
PopulateMetafields value for metadata table will never get updated once metadata table get initialized for the first time. With 0.11, we are making populate meta fields as false for metadata table which was true by default in 0.10.0. So fixing the update in this patch by re-initializing the metaclient if property value has changed. Every other property is statically configured except this config which user can override. hence had to fix just one property.
Brief change log
Add re-intialization of metadata table metaclient and table config if populate meta fields have changed.
Verify this pull requests
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.