[HUDI-3069] Improve HoodieMergedLogRecordScanner avoid putting unnecessary hoodie records #4932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
old pr : #4400 |
danny0405
reviewed
Mar 2, 2022
| records.put(key, new HoodieAvroRecord<>(new HoodieKey(key, hoodieRecord.getPartitionPath()), combinedValue, operation)); | ||
| // If combinedValue is oldValue, no need rePut oldRecord | ||
| if (!combinedValue.equals(oldValue)) { | ||
| HoodieOperation operation = hoodieRecord.getOperation(); |
Contributor
There was a problem hiding this comment.
We can use == instead which is more efficient. Currently the payload clazz has no uniform #equals yet.
Contributor
Author
There was a problem hiding this comment.
fixed. please review again.
Collaborator
nsivabalan
approved these changes
Mar 3, 2022
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
LGTM. thanks for the contribution!
danny0405
changed the title
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…ssary hoodie records (apache#4932) * log scanner optimization * payload equals switches to `=` Co-authored-by: 苏承祥 <[email protected]>
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
…ssary hoodie records (apache#4932) * log scanner optimization * payload equals switches to `=` Co-authored-by: 苏承祥 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
when reading the delta log file, we compare the data in the external spillablemap with the delta log data. If oldrecord is selected, there is no need to rewrite the data in the external spillablemap. Rewriting data will waste a lot of resources when data is spill to disk
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.