[HUDI-3441] Add support for "marker delete" in hudi-cli #4922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuQianJin-Stars
changed the title
leesf
reviewed
Feb 28, 2022
hudi-cli/src/main/java/org/apache/hudi/cli/commands/MarkersCommand.java
Outdated
Show resolved
Hide resolved
leesf
reviewed
Feb 28, 2022
hudi-cli/src/main/java/org/apache/hudi/cli/commands/MarkersCommand.java
Outdated
Show resolved
Hide resolved
nsivabalan
added
priority:blocker
Contributor
|
Can you fix the description of the PR. we have a template to assist. I understand the jira will have the info. You can just copy paste most things from there. but lets try to see if we can fill in the description for diff sections. |
leesf
approved these changes
Mar 1, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
For r0.9.0 and before, there is a bug that the markers from compaction action are not cleaned up after the commit is complete. There is a fix going in after r0.9.0 and before r0.10.0 regarding the marker cleanup for compaction: https://github.com/apache/hudi/pull/3576. For tables with r0.9.0 and before, the makers are going to exist without cleanup.
We should clean up the Hudi markers of completed commits inside .temp if they are not cleaned up due to older release. This process can be inside upgrade process and a cli command as well.
Jira link: HUDI-3441
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.