[HUDI-3520] Introduce DeleteSupportSchemaPostProcessor to support adding _hoodie_is_deleted column to schema #4921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxianghu
force-pushed
the
HUDI-3520
branch
from
2a7b4e0 to
89eb9f6
Compare
Contributor
|
@alexeykudinkin : Can you review this please. |
wangxianghu
force-pushed
the
HUDI-3520
branch
from
89eb9f6 to
71dd885
Compare
nsivabalan
reviewed
Mar 2, 2022
...c/main/java/org/apache/hudi/utilities/schema/processor/DeleteSupportSchemaPostProcessor.java
Outdated
Show resolved
Hide resolved
...-utilities/src/main/java/org/apache/hudi/utilities/schema/processor/SchemaPostProcessor.java
Outdated
Show resolved
Hide resolved
wangxianghu
force-pushed
the
HUDI-3520
branch
6 times, most recently
from
50e7fc8 to
4a265c6
Compare
Contributor
Author
|
@nsivabalan please take another look when free |
…ing _hoodie_is_deleted column to schema
pratyakshsharma
changed the title
Contributor
|
This adds a useful missing piece. Thank you for contributing this @wangxianghu |
nsivabalan
approved these changes
Mar 6, 2022
Contributor
nsivabalan
left a comment
nsivabalan
left a comment
There was a problem hiding this comment.
LGTM. I see we are adding few schema post processors (delete in this patch, and then json in another patch).
So, can you look into adding support for multiple schema post processors in general to deltastreamer (in a follow up patch).
Contributor
Author
|
@nsivabalan |
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…ing _hoodie_is_deleted column to schema (apache#4921)
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
…ing _hoodie_is_deleted column to schema (apache#4921)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
In our use case, data is read from kafka(binlog with some preprocess), schema read from hive, we need
add
_hoodie_is_deletedcolumn to schema to support delete operationBrief change log
(for example:)
Verify this pull request
This pull request is already covered by existing tests, such as:
org.apache.hudi.utilities.schema.TestSchemaPostProcessor#testDeleteSupport
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.