[HUDI-3521] Fixing kafka key and value serializer value type from class to string #4919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
added
priority:blocker
Collaborator
Contributor
Author
|
@codope : went ahead w/ merging since this is critical. If you have any feedback, will address in a follow up PR. |
Member
|
Looks good to me. I was just waiting for CI success 👍 |
rkkalluri
pushed a commit
to rkkalluri/hudi
that referenced
this pull request
Mar 6, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
With latest addition of TypedProperties in HoodieTableConfig, we ran into issues w/ kafka key and value serializer types in properties. Apparently value type was class and hence when getting string values, it returns null values while populating TypedProperties. Fixed all such instances of key.serializer and value.serializer instantiations.
Brief change log
Fixed all instantiations of key.serializer and value.serializer to ensure value is of type string.
Verify this pull request
docker demo runs successfully w/o NPE w/ this patch.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.