Skip to content

Conversation

@stayrascal
Copy link
Contributor

Tips

What is the purpose of the pull request

  • Fix NPE problem during search Flink builtin function TO_DATE('xxx') while enable Hudi catalog, because the original logic of getPartition(ObjectPath tablePath, CatalogPartitionSpec catalogPartitionSpec) is return null, which will caused NPE problem.

image

Brief change log

  • Replace null with FunctionNotExistException of getFunction method in HoodieCatalog.java
  • Replace null with PartitionNotExistException of getPartition method in HoodieCatalog.java
  • Add a IT case to test get builtin function
  • Change TableSchema to ResolveSchema in ContinousFileSource.java

Verify this pull request

  • Added integration tests(testBuiltinFunctionWithCatalog) in HoodieDataSourceITCase.java

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan
Copy link
Contributor

@danny0405 : feel free to ask someone else to review if you are occupied w/ other work items.

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@danny0405 danny0405 merged commit 3cfb52c into apache:master Mar 2, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants