Skip to content

Conversation

@cuibo01
Copy link
Contributor

@cuibo01 cuibo01 commented Feb 25, 2022

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@cuibo01 cuibo01 force-pushed the hudi-3460 branch 3 times, most recently from f0dbae2 to 834d069 Compare February 26, 2022 10:51
@nsivabalan
Copy link
Contributor

@danny0405 @leesf : have assigned the PR to you folks. if you guys are occupied and can't review, feel free to pull in someone else to assist in reviewing. thanks!

@nsivabalan nsivabalan added the engine:flink Flink integration label Mar 1, 2022
@cuibo01 cuibo01 force-pushed the hudi-3460 branch 4 times, most recently from 8c093d1 to 06c67a2 Compare March 3, 2022 10:31
@cuibo01
Copy link
Contributor Author

cuibo01 commented Mar 4, 2022

@hudi-bot run azure

@danny0405 danny0405 changed the title [HUDI-3460]Flink TM memory Optimization [HUDI-3460] Add reader merge memory option for flink Mar 4, 2022
Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@hudi-bot
Copy link
Collaborator

hudi-bot commented Mar 4, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 0986d5a into apache:master Mar 4, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine:flink Flink integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants