[HUDI-3486] Fix wrong field order for constructing HoodieMetadataColumnStats #4875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR fixes the problem of incorrect value and null count read from column stats in metadata table. The root cause is the wrong order of arguments passed to the constructor of
HoodieMetadataColumnStats. The constructor is:and the original init is
The actual values of
valueCountandnullCountpassed in are switched.(Below screenshot shows the diff of column stats from validation: left: from metadata table, right: from base files (ground truth))
Brief change log
HoodieMetadataColumnStatsinHoodieMetadataPayloadto set each field explicitly.Verify this pull request
Runs Hudi Deltastreamer continuous mode writing MOR table, async compaction, cleaner, all multi-modal indexing enabled and verifies that after the fix, the column stats from metadata table is correct compared to the ground truth from base files.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.