Skip to content

Conversation

@xushiyan
Copy link
Member

@xushiyan xushiyan commented Feb 21, 2022

  • Adopt HoodieData in Spark action commit executors
  • Make Spark independent DeleteHelper, WriteHelper, MergeHelper in hudi-client-common
  • Make HoodieTable in WriteClient APIs have raw type to decouple with Client's generic types

@xushiyan xushiyan changed the title Hudi 2439 refactoring spark commit executors [HUDI-2439] Refactor Spark commit action executors Feb 21, 2022
@xushiyan xushiyan force-pushed the HUDI-2439-refactoring-spark-commit-executors branch 4 times, most recently from 8bdb930 to 58ac0ed Compare February 25, 2022 14:17
@xushiyan xushiyan force-pushed the HUDI-2439-refactoring-spark-commit-executors branch 2 times, most recently from f44ffdb to 146e710 Compare March 2, 2022 12:55
@xushiyan xushiyan changed the title [HUDI-2439] Refactor Spark commit action executors [HUDI-2439] Replace RDD with HoodieData in HoodieSparkTable and commit executors Mar 2, 2022
@xushiyan xushiyan force-pushed the HUDI-2439-refactoring-spark-commit-executors branch 3 times, most recently from 0371840 to 55d3617 Compare March 2, 2022 13:44
@xushiyan xushiyan force-pushed the HUDI-2439-refactoring-spark-commit-executors branch from 55d3617 to 801d0ae Compare March 2, 2022 13:52
@xushiyan xushiyan marked this pull request as ready for review March 2, 2022 13:52
@xushiyan xushiyan requested a review from yihua March 2, 2022 13:55
@xushiyan xushiyan force-pushed the HUDI-2439-refactoring-spark-commit-executors branch 3 times, most recently from 2aa57d9 to 8de07cc Compare March 8, 2022 01:30
import org.apache.hudi.table.HoodieTable;

import org.apache.spark.api.java.JavaRDD;
public class HoodieWriteHelper<T extends HoodieRecordPayload, R> extends BaseWriteHelper<T, HoodieData<HoodieRecord<T>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar here for the write helper regarding Flink, Java, and BaseWriteHelper.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihua
Copy link
Contributor

yihua commented Mar 10, 2022

As long as we don't touch public-facing APIs marked by @PublicAPIClass the refactoring should be good to go after fixing all my comments.

@xushiyan xushiyan force-pushed the HUDI-2439-refactoring-spark-commit-executors branch 4 times, most recently from ef731b3 to 1969d6f Compare March 14, 2022 01:21
@xushiyan xushiyan requested a review from yihua March 14, 2022 16:17
@nsivabalan
Copy link
Contributor

@xushiyan : can you tag w/ right priority

@xushiyan xushiyan added the priority:blocker Production down; release blocker label Mar 17, 2022
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xushiyan xushiyan force-pushed the HUDI-2439-refactoring-spark-commit-executors branch from 1969d6f to 1e90c19 Compare March 17, 2022 06:35
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xushiyan xushiyan merged commit 7446ff9 into apache:master Mar 17, 2022
@xushiyan xushiyan deleted the HUDI-2439-refactoring-spark-commit-executors branch March 17, 2022 11:17
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
…t executors (apache#4856)

- Adopt HoodieData in Spark action commit executors
- Make Spark independent DeleteHelper, WriteHelper, MergeHelper in hudi-client-common
- Make HoodieTable in WriteClient APIs have raw type to decouple with Client's generic types
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
…t executors (apache#4856)

- Adopt HoodieData in Spark action commit executors
- Make Spark independent DeleteHelper, WriteHelper, MergeHelper in hudi-client-common
- Make HoodieTable in WriteClient APIs have raw type to decouple with Client's generic types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:blocker Production down; release blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants