Skip to content

Conversation

@nsivabalan
Copy link
Contributor

@nsivabalan nsivabalan commented Feb 18, 2022

What is the purpose of the pull request

  • "_hoodie_is_deleted" is more a reserved field in hoodie. Hoodie uses that to interpret a record as active or deleted. But the field as such is optional. So, adding extra validation to ensure if the field is present, it has to be of type Boolean.

Brief change log

  • Adding extra validation to SqlWriter to ensure if "_hoodie_is_deleted" field is present, it has to be of type Boolean.

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added tests to TestCOWDataSource to test the fix.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan nsivabalan changed the title [HUDI-3018] Adding validation to dataframe scheme to ensure reserved field does not have diff data type [HUDI-3018] Adding validation to dataframe schema to ensure reserved field does not have diff data type Feb 18, 2022
@nsivabalan nsivabalan force-pushed the addIsHoodieDeletedSchemaValidation branch from 294c46a to a1538ba Compare February 23, 2022 17:54
Copy link
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please rebase?

@nsivabalan nsivabalan force-pushed the addIsHoodieDeletedSchemaValidation branch from a1538ba to 01ec026 Compare February 25, 2022 16:29
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan merged commit d5444ff into apache:master Feb 27, 2022
rkkalluri pushed a commit to rkkalluri/hudi that referenced this pull request Mar 6, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants