[HUDI-3042] Abstract Spark update Strategy to make code more clean and remove duplicates #4845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneanxs
changed the title
Contributor
Author
|
@codope @nsivabalan Hi, can you review this? |
codope
reviewed
Feb 18, 2022
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| public abstract class BaseSparkUpdateStrategy<T extends HoodieRecordPayload<T>> extends UpdateStrategy<T, JavaRDD<HoodieRecord<T>>> { |
Member
There was a problem hiding this comment.
let's add a javadoc for public classes and methods.
added 2 commits
February 20, 2022 14:57
Contributor
Author
|
@hudi-bot run azure |
1 similar comment
Contributor
Author
|
@hudi-bot run azure |
xushiyan
approved these changes
Feb 21, 2022
Member
xushiyan
left a comment
xushiyan
left a comment
There was a problem hiding this comment.
LGTM. I'm working on a broader refactoring that needs and covers this. https://issues.apache.org/jira/browse/HUDI-3042
xushiyan
changed the title
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…d remove duplicates (apache#4845) Co-authored-by: Hui An <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.