-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-3450] Avoid passing empty string spark master to hudi cli #4844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-3450] Avoid passing empty string spark master to hudi cli #4844
Conversation
| sparkMasterNode = properties.getProperty(HoodieCliSparkConfig.CLI_SPARK_MASTER); | ||
| } | ||
| sparkMasterNode = sparkMaster.orElse(sparkMasterNode); | ||
| if (sparkMaster.isPresent() && !sparkMaster.get().isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!sparkMaster.get().isEmpty() -> !sparkMaster.get().trim().isEmpty()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
|
@zhedoubushishi : can you address comments when you get a chance. |
d19d7a0 to
63bb52d
Compare
|
@nsivabalan Resolved the comment. |
I approve it |
|
LGTM , Thanks @zhedoubushishi |
…he#4844) Co-authored-by: Wenning Ding <[email protected]>
…he#4844) Co-authored-by: Wenning Ding <[email protected]>
…he#4844) Co-authored-by: Wenning Ding <[email protected]>
Tips
What is the purpose of the pull request
When not passing SparkMaster, by default Hudi CLI should use SparkUtil.DEFAULT_SPARK_MASTER. However, w/ a recent code change in OSS, when SparkMaster is not passed, it would set Spark master to "" which causes the following exception when initializing a Hudi CLI job:
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.