Skip to content

[HUDI-3440] HoodieSortedMergeHandle#close write data disorder #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangxianghu merged 6 commits into from
Feb 18, 2022
Merged

[HUDI-3440] HoodieSortedMergeHandle#close write data disorder #4841

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee9ae14
Merge pull request #1 from apache/master
loukey-lj Jan 26, 2021
3fb10f7
Merge branch 'apache:master' into master
loukey-lj May 30, 2021
0fa6348
Merge branch 'apache:master' into master
loukey-lj Feb 16, 2022
9427b43
Merge branch 'apache:master' into master
loukey-lj Feb 17, 2022
99bf8f2
Merge branch 'apache:master' into master
loukey-lj Feb 17, 2022
416d8ab
HoodieSortedMergeHandle#close write data disorder
Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieSortedMergeHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,9 @@ public void write(GenericRecord oldRecord) {
@Override
public List<WriteStatus> close() {
// write out any pending records (this can happen when inserts are turned into updates)
newRecordKeysSorted.stream().forEach(key -> {
while (!newRecordKeysSorted.isEmpty()) {
try {
String key = newRecordKeysSorted.poll();
HoodieRecord<T> hoodieRecord = keyToNewRecords.get(key);
if (!writtenRecordKeys.contains(hoodieRecord.getRecordKey())) {
if (useWriterSchema) {
Expand All @@ -122,7 +123,7 @@ public List<WriteStatus> close() {
} catch (IOException e) {
throw new HoodieUpsertException("Failed to close UpdateHandle", e);
}
});
}
newRecordKeysSorted.clear();
keyToNewRecords.clear();

Expand Down