[HUDI-3446][HUDI-FLINK] support batch Reader in BootstrapOperator#loadRecords #4837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
hi @danny0405, pls review the pr :) |
cuibo01
force-pushed
the
supportBatchRead
branch
2 times, most recently
from
a3ad7ea to
7f14898
Compare
cuibo01
force-pushed
the
supportBatchRead
branch
from
7f14898 to
38e390e
Compare
danny0405
requested changes
Feb 18, 2022
hudi-common/src/main/java/org/apache/hudi/common/util/BaseFileUtils.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/util/BaseFileUtils.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/util/BaseFileUtils.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/util/OrcUtils.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/util/OrcUtils.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/util/OrcUtils.java
Outdated
Show resolved
Hide resolved
hudi-flink/src/main/java/org/apache/hudi/sink/bootstrap/BootstrapOperator.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
thx for your review @danny0405 |
cuibo01
force-pushed
the
supportBatchRead
branch
4 times, most recently
from
2ca7c18 to
868fa61
Compare
cuibo01
force-pushed
the
supportBatchRead
branch
from
868fa61 to
3ca0191
Compare
Contributor
|
HUDI-3446.patch.zip |
Contributor
Author
The PR is correct by TestParquetUtils#testFetchRecordKeyPartitionPathFromParquet |
Contributor
|
Did you notice that i have attached a patch for this pr? Please apply it then |
cuibo01
force-pushed
the
supportBatchRead
branch
from
1ab83de to
9c8cd84
Compare
danny0405
approved these changes
Feb 19, 2022
Contributor
danny0405
left a comment
danny0405
left a comment
There was a problem hiding this comment.
+1, thanks for the contribution ~
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…pache#4837) * [HUDI-3446] Supports batch Reader in BootstrapOperator#loadRecords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dRecords
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.