[HUDI-3438] Avoid getSmallFiles if hoodie.parquet.small.file.limit is 0 #4823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hudi-bot run azure |
1 similar comment
Contributor
Author
|
@hudi-bot run azure |
YuweiXiao
reviewed
Feb 16, 2022
| private Map<String, List<SmallFile>> getSmallFilesForPartitions(List<String> partitionPaths, HoodieEngineContext context) { | ||
| Map<String, List<SmallFile>> partitionSmallFilesMap = new HashMap<>(); | ||
|
|
||
| if (config.getParquetSmallFileLimit() == 0) { |
Contributor
There was a problem hiding this comment.
How about using <= 0 to indicate always writing to new file group? And maybe add a description of this behavior to the document of PARQUET_SMALL_FILE_LIMIT.
Contributor
Author
There was a problem hiding this comment.
Can PARQUET_SMALL_FILE_LIMIT be set to be negative? I'm not sure.
Yeah, I'll add the description to the PARQUET_SMALL_FILE_LIMIT
Contributor
There was a problem hiding this comment.
It is possible to be set it to negative, which is meaningless of course. So I guess we could cover it as well?
nsivabalan
approved these changes
Feb 17, 2022
Collaborator
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
… 0 (apache#4823) Co-authored-by: Hui An <hui.an@shopee.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Method
getSmallFilescould be very time consuming if there are many small files in one partitionPath. Though we already sethoodie.parquet.small.file.limitto 0, it will still callgetSmallFilesto do the comparison, this could be avoided.Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.