Skip to content

Conversation

@pratyakshsharma
Copy link
Contributor

@pratyakshsharma pratyakshsharma commented Feb 9, 2022

Tips

What is the purpose of the pull request

Made schema registry url configs more flexible as per the request in #4585

Brief change log

  • Added a check for source and target schema registry urls in table overridden properties
  • Added test cases

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link
Collaborator

hudi-bot commented Feb 9, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratyakshsharma : did you get a chance to test the patch out. Seems straight forward. but just asking.

@nsivabalan nsivabalan added the priority:high Significant impact; potential bugs label Feb 25, 2022
@nsivabalan nsivabalan assigned nsivabalan and unassigned codope Feb 25, 2022
@pratyakshsharma
Copy link
Contributor Author

@pratyakshsharma : did you get a chance to test the patch out. Seems straight forward. but just asking.

No I have just written test cases, and they were passing.

@nsivabalan nsivabalan merged commit 907e60c into apache:master Mar 2, 2022
@nsivabalan
Copy link
Contributor

@pratyakshsharma : Can you update the multi table deltastreamer blog regarding this.

@pratyakshsharma
Copy link
Contributor Author

ack.

vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
@ROOBALJINDAL
Copy link

@pratyakshsharma : Can you update the multi table deltastreamer blog regarding this.

It is done? Can anyone take care of this? This is needed as its not clear what is exactly expected in the new configuration.

@pratyakshsharma
Copy link
Contributor Author

@ROOBALJINDAL This somehow slipped off my radar. Let me take care of this in a day or two. If you are looking for some immediate assistance, we can probably connect on slack. You can find me with 'Pratyaksh Sharma' there.

@pratyakshsharma
Copy link
Contributor Author

#6420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:high Significant impact; potential bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants