-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-3264]: made schema registry urls configurable with MTDS #4779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nsivabalan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pratyakshsharma : did you get a chance to test the patch out. Seems straight forward. but just asking.
No I have just written test cases, and they were passing. |
|
@pratyakshsharma : Can you update the multi table deltastreamer blog regarding this. |
|
ack. |
It is done? Can anyone take care of this? This is needed as its not clear what is exactly expected in the new configuration. |
|
@ROOBALJINDAL This somehow slipped off my radar. Let me take care of this in a day or two. If you are looking for some immediate assistance, we can probably connect on slack. You can find me with 'Pratyaksh Sharma' there. |
Tips
What is the purpose of the pull request
Made schema registry url configs more flexible as per the request in #4585
Brief change log
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.