Skip to content

Conversation

@alexeykudinkin
Copy link
Contributor

@alexeykudinkin alexeykudinkin commented Feb 8, 2022

Tips

What is the purpose of the pull request

NOTE: This PR is WIP, DO NOT REVIEW YET

Revisit HoodieRecord to replace HoodieRecordPayload usage.

This is preparatory change collecting portion of the required (but not sufficient) changes to be able to replace HoodieRecordPayload and raw Avro payload handling with interfacing with HoodieRecord instead.

Brief change log

  • Mirroring (temporarily) existing HoodieRecordPayload APIs into HoodieRecord
  • Adding HoodieFileWriter, HoodieFileReader abstractions operating on HoodieRecord
  • Minor refactorings/cleanups

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@alexeykudinkin alexeykudinkin marked this pull request as draft February 8, 2022 20:16
@hudi-bot
Copy link
Collaborator

hudi-bot commented Feb 9, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@vinothchandar vinothchandar added the rfc Request for comments label Feb 17, 2022
@xushiyan xushiyan added big-needle-movers and removed rfc Request for comments labels May 19, 2022
@vinothchandar
Copy link
Member

@xushiyan should we close this PR? the equivalent changes as a part of RFC-46 have already been landed?

@alexeykudinkin
Copy link
Contributor Author

Closing in favor of #5522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants