[HUDI-2596] Make class names consistent in hudi-client #4680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
force-pushed
the
HUDI-2596
branch
2 times, most recently
from
ae88c2f to
5593a7e
Compare
yihua
reviewed
Jan 27, 2022
Contributor
yihua
left a comment
yihua
left a comment
There was a problem hiding this comment.
Overall LGTM. Left a few comments on the naming.
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/AsyncClusteringService.java
Show resolved
Hide resolved
...ient/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/OneToZeroDowngrader.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/apache/hudi/metrics/userdefined/AbstractUserDefinedMetricsReporter.java
Show resolved
Hide resolved
cuibo01
added a commit
to cuibo01/hudi
that referenced
this pull request
Jan 28, 2022
[HUDI-2596] Make class names consistent in hudi-client (apache#4680)
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.