Add default value as null for S3 Incremental source properties #4674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
reviewed
Jan 24, 2022
| filter = filter + " and s3.object.key like '" + props.getString(Config.S3_KEY_PREFIX) + "%'"; | ||
| } | ||
| if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_IGNORE_KEY_PREFIX))) { | ||
| if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_IGNORE_KEY_PREFIX, null))) { |
Contributor
Author
There was a problem hiding this comment.
We need the folder prefix as a required argument I guess right ? Otherwise incremental job will ingest all the files in the bucket.
Contributor
There was a problem hiding this comment.
ok, I was thinking what incase user is interested to pull all data for a given bucket.
Contributor
Author
There was a problem hiding this comment.
@codope did you folks have any discussion around this when the 2 stage pipeline support was added ?
Collaborator
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Jan 25, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
nsivabalan
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Feb 9, 2022
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
hoodie.deltastreamer.source.s3incr.ignore.key.prefixandhoodie.deltastreamer.source.s3incr.ignore.key.substringcan be null and are not required parameters. UsinggetStringwas throwingIllegalArgumentException(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.