[Minor]change log info and if-else logic in metadata table #4673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @nsivabalan and @yihua would you mind to take a look at your convince? Thanks a lot ! |
Collaborator
Contributor
|
@nsivabalan do you want to double check the changes? |
nsivabalan
approved these changes
Jan 24, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Jan 25, 2022
…pache#4673) Co-authored-by: yuezhang <[email protected]>
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
…pache#4673) Co-authored-by: yuezhang <[email protected]>
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
…pache#4673) Co-authored-by: yuezhang <[email protected]>
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…pache#4673) Co-authored-by: yuezhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little change want to do during reading meta data table related code.
HoodieMetadataConfig.IGNORE_SPURIOUS_DELETES.key() + " config is set to false"->HoodieMetadataConfig.IGNORE_SPURIOUS_DELETES.key() + " config is set to true"metadataConfig.ignoreSpuriousDeletes()instead of!metadataConfig.ignoreSpuriousDeletes()(a little confusing). Maybe can just ignore when set ignore true.Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.