-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-3239] Convert BaseHoodieTableFileIndex to Java
#4669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
89266f9 to
f01e128
Compare
|
@alexeykudinkin Thanks for your contribution! Can you figure out why CI failed? |
f01e128 to
851e61c
Compare
BaseHoodieTableFileIndex to JavaBaseHoodieTableFileIndex to Java
54e68ec to
7d12ce8
Compare
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieTableQueryType.java
Show resolved
Hide resolved
hudi-common/src/main/scala/org/apache/hudi/BaseHoodieTableFileIndex.scala
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/util/Option.java
Outdated
Show resolved
Hide resolved
yihua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on converting BaseHoodieTableFileIndex from Scala to Java
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/JavaBaseHoodieTableFileIndex.java
Show resolved
Hide resolved
7d12ce8 to
9c7024e
Compare
…`JavaHoodieTableFileIndex`
44a8d36 to
a3a625c
Compare
BaseHoodieTableFileIndex to JavaBaseHoodieTableFileIndex to Java
|
|
||
| <!-- TODO(HUDI-3239) remove this --> | ||
| <include>org.scala-lang:scala-library</include> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the following dep be removed in this pom as well? Similar for the other bundle poms, hudi-hadop-mr/pom.xml,hudi-common/pom.xml where scala dep is added in #4531.
<!-- Scala -->
<!-- TODO(HUDI-3239) remove this dep -->
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
<version>${scala.version}</version>
</dependency>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, great catch!
Did mindless search and delete somehow bundles didn't bubble up in it. Sorry about that.
yihua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I put up two more nits regarding the hudi-common pom.
hudi-common/pom.xml
Outdated
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the <pluginManagement> be removed altogether? I see maven-compiler-plugin is added before mainly for compiling both Java and Scala code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
hudi-common/pom.xml
Outdated
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here for this plugin.
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieTableQueryType.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieTableQueryType.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieTableQueryType.java
Show resolved
Hide resolved
|
@hudi-bot run azure |
Converting BaseHoodieTableFileIndex to Java, removing Scala as a dependency from "hudi-common"
Converting BaseHoodieTableFileIndex to Java, removing Scala as a dependency from "hudi-common"
Tips
What is the purpose of the pull request
Converting
BaseHoodieTableFileIndexto Java, removing Scala as a dependency from "hudi-common"Brief change log
See above
Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.