Skip to content

Conversation

@alexeykudinkin
Copy link
Contributor

@alexeykudinkin alexeykudinkin commented Jan 22, 2022

Tips

What is the purpose of the pull request

Converting BaseHoodieTableFileIndex to Java, removing Scala as a dependency from "hudi-common"

Brief change log

See above

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yanghua
Copy link
Contributor

yanghua commented Jan 25, 2022

@alexeykudinkin Thanks for your contribution! Can you figure out why CI failed?

@alexeykudinkin alexeykudinkin changed the title [HUDI-3239] Convert BaseHoodieTableFileIndex to Java [HUDI-3239][Stacked on 4667] Convert BaseHoodieTableFileIndex to Java Jan 29, 2022
@alexeykudinkin
Copy link
Contributor Author

@yanghua there's a long stack of PRs, and there were issues w/ Metadata Table that were failing tests in the PR at the very bottom of it.

These issues have been addressed here in #4716, and as soon as it lands i'll rebase onto it.

@yanghua
Copy link
Contributor

yanghua commented Feb 1, 2022

@yanghua there's a long stack of PRs, and there were issues w/ Metadata Table that were failing tests in the PR at the very bottom of it.

These issues have been addressed here in #4716, and as soon as it lands i'll rebase onto it.

Sounds good.

@alexeykudinkin alexeykudinkin force-pushed the ak/rpath-ref-7 branch 2 times, most recently from 54e68ec to 7d12ce8 Compare February 3, 2022 22:32
@yihua yihua self-assigned this Feb 4, 2022
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on converting BaseHoodieTableFileIndex from Scala to Java

@alexeykudinkin alexeykudinkin changed the title [HUDI-3239][Stacked on 4667] Convert BaseHoodieTableFileIndex to Java [HUDI-3239] Convert BaseHoodieTableFileIndex to Java Feb 8, 2022

<!-- TODO(HUDI-3239) remove this -->
<include>org.scala-lang:scala-library</include>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the following dep be removed in this pom as well? Similar for the other bundle poms, hudi-hadop-mr/pom.xml,hudi-common/pom.xml where scala dep is added in #4531.

    <!-- Scala -->
    <!-- TODO(HUDI-3239) remove this dep -->
    <dependency>
      <groupId>org.scala-lang</groupId>
      <artifactId>scala-library</artifactId>
      <version>${scala.version}</version>
    </dependency>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great catch!
Did mindless search and delete somehow bundles didn't bubble up in it. Sorry about that.

Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I put up two more nits regarding the hudi-common pom.

</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the <pluginManagement> be removed altogether? I see maven-compiler-plugin is added before mainly for compiling both Java and Scala code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here for this plugin.

@alexeykudinkin
Copy link
Contributor Author

@hudi-bot run azure

@hudi-bot
Copy link
Collaborator

hudi-bot commented Feb 9, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan merged commit 464027e into apache:master Feb 9, 2022
liusenhua pushed a commit to liusenhua/hudi that referenced this pull request Mar 1, 2022
Converting BaseHoodieTableFileIndex to Java, removing Scala as a dependency from "hudi-common"
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
Converting BaseHoodieTableFileIndex to Java, removing Scala as a dependency from "hudi-common"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants