Skip to content

[MINOR] Fixing serializability for ListingBasedRollbackRequest #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsivabalan merged 1 commit into from
Jan 26, 2022
Merged

[MINOR] Fixing serializability for ListingBasedRollbackRequest #4655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...mmon/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@

import org.apache.hudi.common.util.Option;

import java.io.Serializable;

/**
* Request for performing one rollback action.
*/
public class ListingBasedRollbackRequest {
public class ListingBasedRollbackRequest implements Serializable {
Copy link
Contributor

@yihua yihua Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test case for this change, i.e., a test with Spark engine context to show that without the Serializable the test fails, while adding this is necessary to pass the test?


/**
* Rollback commands, that trigger a specific handling for rollback.
Expand Down