Skip to content

Conversation

@zhangyue19921010
Copy link
Contributor

https://issues.apache.org/jira/projects/HUDI/issues/HUDI-3281

What is the purpose of the pull request

Current implement of getAllPartitionPaths API list/collect all the data files and check .hoodie_partition_metadata in these files.
As we know list is a pretty heavy action especially in scenarios where S3 is used as storage.
We sometimes can see 20+ seconds for a single list action causing streaming job delay.

Brief change log

Just check if partitions/.hoodie_partition_metadata exists instead of getting all the data files under partitions.

Here are the test result based on S3
image

time1 time2 time3 time4 time5 time6 time7 time8 time9 time10 avg(ms)
Original 6045 5627 5736 5697 5733 5321 5462 5700 6072 5367 5676
Optimized 2888 2730 2717 2680 2684 2778 2650 2728 3107 2908 2787

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. good optimization :)

@nsivabalan
Copy link
Contributor

CC @yihua @manojpec

@nsivabalan nsivabalan merged commit 79bf6ab into apache:master Jan 20, 2022
@zhangyue19921010
Copy link
Contributor Author

@nsivabalan Thanks a lot for your help!

@vinishjail97 vinishjail97 mentioned this pull request Jan 24, 2022
5 tasks
alexeykudinkin pushed a commit to onehouseinc/hudi that referenced this pull request Jan 25, 2022
…I in FileSystemBackedTableMetadata (apache#4643)


Co-authored-by: yuezhang <[email protected]>
vingov pushed a commit to vingov/hudi that referenced this pull request Jan 26, 2022
…I in FileSystemBackedTableMetadata (apache#4643)


Co-authored-by: yuezhang <[email protected]>
liusenhua pushed a commit to liusenhua/hudi that referenced this pull request Mar 1, 2022
…I in FileSystemBackedTableMetadata (apache#4643)


Co-authored-by: yuezhang <[email protected]>
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
…I in FileSystemBackedTableMetadata (apache#4643)


Co-authored-by: yuezhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants