[HUDI-3254] Introduce HoodieCatalog to manage tables for Spark Datasource V2 #4611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leesf
force-pushed
the
HUDI-3254
branch
3 times, most recently
from
5feee50 to
7df4b2c
Compare
Member
5 tasks
leesf
force-pushed
the
HUDI-3254
branch
2 times, most recently
from
b6b74ca to
addb9f9
Compare
Contributor
Author
|
@hudi-bot run azure |
YannByron
reviewed
Jan 23, 2022
...di-spark3/src/main/scala/org/apache/spark/sql/connector/catalog/HoodieIdentifierHelper.scala
Outdated
Show resolved
Hide resolved
YannByron
reviewed
Jan 23, 2022
...rce/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSpark3Analysis.scala
Show resolved
Hide resolved
YannByron
reviewed
Jan 23, 2022
| val tableSchema = HoodieSqlCommonUtils.getTableSqlSchema(metaClient) | ||
| if (tableSchema.isDefined && schema.isEmpty) { | ||
| // Fill the schema with the schema from the table | ||
| c.copy(tableSchema = tableSchema.get) |
Contributor
There was a problem hiding this comment.
i think we don't need to fill the table schema in here. We can move this process to HoodieCatalog.createHoodieTable.
YannByron
reviewed
Jan 23, 2022
...rce/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSpark3Analysis.scala
Outdated
Show resolved
Hide resolved
xushiyan
reviewed
Jan 24, 2022
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/SparkAdapter.scala
Show resolved
Hide resolved
...source/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala
Outdated
Show resolved
Hide resolved
...mon/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableAddColumnsCommand.scala
Outdated
Show resolved
Hide resolved
...datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala
Outdated
Show resolved
Hide resolved
...source/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieConfigHelper.scala
Outdated
Show resolved
Hide resolved
...source/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieConfigHelper.scala
Show resolved
Hide resolved
...rce/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieInternalV2Table.scala
Outdated
Show resolved
Hide resolved
...rce/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/HoodieInternalV2Table.scala
Outdated
Show resolved
Hide resolved
...atasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/BaseStagedTable.scala
Outdated
Show resolved
Hide resolved
xushiyan
reviewed
Jan 30, 2022
Member
xushiyan
left a comment
xushiyan
left a comment
There was a problem hiding this comment.
@leesf I had another pass. I think overall logics make sense. Do you have any test plans for this change? feel free to share any test setup you have. It'll be much preferred to see some tests results to help verify the end-to-end functionalities.
...-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/IncrementalRelation.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlUtils.scala
Show resolved
Hide resolved
...datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3SqlUtils.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark3/src/main/scala/org/apache/hudi/Spark3DefaultSource.scala
Outdated
Show resolved
Hide resolved
...atasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/BaseStagedTable.scala
Outdated
Show resolved
Hide resolved
...atasource/hudi-spark3/src/main/scala/org/apache/spark/sql/hudi/catalog/BaseStagedTable.scala
Outdated
Show resolved
Hide resolved
5 tasks
nsivabalan
added
priority:critical
leesf
force-pushed
the
HUDI-3254
branch
2 times, most recently
from
2d6d4b7 to
b67b0c1
Compare
xushiyan
approved these changes
Feb 14, 2022
Member
|
verified via spark shell basic read write are working cc @leesf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Introduce HoodieCatalog to manage Hudi tables for Spark Datasource V2.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.