Skip to content

[MINOR] Fix delete unused parameter in TablePathUtils#4595

Merged
yihua merged 1 commit intoapache:masterfrom
Timzhang01:cleancode
Jan 17, 2022
Merged

[MINOR] Fix delete unused parameter in TablePathUtils#4595
yihua merged 1 commit intoapache:masterfrom
Timzhang01:cleancode

Conversation

@Timzhang01
Copy link
Copy Markdown
Contributor

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@Timzhang01
Copy link
Copy Markdown
Contributor Author

@manasaks @danny0405

Copy link
Copy Markdown
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanghua yanghua changed the title [MINOR] fix delete unused parameter in TablePathUtils [MINOR] Fix delete unused parameter in TablePathUtils Jan 14, 2022
@yanghua
Copy link
Copy Markdown
Contributor

yanghua commented Jan 14, 2022

@hudi-bot run azure

1 similar comment
@Timzhang01
Copy link
Copy Markdown
Contributor Author

@hudi-bot run azure

@hudi-bot
Copy link
Copy Markdown
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit ed92c21 into apache:master Jan 17, 2022
@vinishjail97 vinishjail97 mentioned this pull request Jan 24, 2022
5 tasks
vingov pushed a commit to vingov/hudi that referenced this pull request Jan 26, 2022
Co-authored-by: zhangxiaotian13 <zhangxiaotian13@jd.com>
liusenhua pushed a commit to liusenhua/hudi that referenced this pull request Mar 1, 2022
Co-authored-by: zhangxiaotian13 <zhangxiaotian13@jd.com>
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
Co-authored-by: zhangxiaotian13 <zhangxiaotian13@jd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants