[HUDI-3072] Fixing conflict resolution in transaction management code path for auto commit code path #4588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@manojpec : Can you review this patch please |
codope
reviewed
Jan 17, 2022
...ient/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java
Outdated
Show resolved
Hide resolved
...ient/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java
Outdated
Show resolved
Hide resolved
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java
Show resolved
Hide resolved
nsivabalan
force-pushed
the
autoCommitConflictCheck
branch
from
ee0c9a3 to
3c51e8e
Compare
codope
approved these changes
Jan 21, 2022
Member
|
@nsivabalan Changes look good. But |
Collaborator
codope
approved these changes
Jan 24, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Jan 25, 2022
… path for auto commit code path (apache#4588) * Fixing conflict resolution in transaction management code path for auto commit code path * Addressing comments * Fixing test failures
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
… path for auto commit code path (apache#4588) * Fixing conflict resolution in transaction management code path for auto commit code path * Addressing comments * Fixing test failures
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
… path for auto commit code path (apache#4588) * Fixing conflict resolution in transaction management code path for auto commit code path * Addressing comments * Fixing test failures
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
… path for auto commit code path (apache#4588) * Fixing conflict resolution in transaction management code path for auto commit code path * Addressing comments * Fixing test failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Looks like conflict resolution had a bug in auto commit code path. Incidentally both spark datasource writer and deltastreamer uses non auto commit code path and hence this was never an issue. Fixing the same in this patch and added tests to verify the fix.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.