[HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency#4574
Merged
nsivabalan merged 1 commit intoapache:masterfrom Jan 12, 2022
Merged
[HUDI-3235] Fix ClassNotFoundException due to log4j-core dependency#4574nsivabalan merged 1 commit intoapache:masterfrom
nsivabalan merged 1 commit intoapache:masterfrom
Conversation
Move log4j-core to top level pom
codope
force-pushed
the
HUDI-3235-fix-log4j
branch
from
3969fac to
9adc0b3
Compare
Collaborator
yihua
reviewed
Jan 12, 2022
| <dependency> | ||
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-core</artifactId> | ||
| <version>2.17.0</version> |
Contributor
There was a problem hiding this comment.
Do we want to set the log4j version here as well?
Member
Author
There was a problem hiding this comment.
declared in top level pom which will be inherited here.
| <dependency> | ||
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-core</artifactId> | ||
| <scope>test</scope> |
nsivabalan
approved these changes
Jan 12, 2022
5 tasks
5 tasks
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
…pache#4574) - Move log4j-core to top level pom
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
…pache#4574) - Move log4j-core to top level pom
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…pache#4574) - Move log4j-core to top level pom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Some of the tests that need hive service to be setup also need log4j-core
AppenderinstantiatingSessionManagerof hive service. This is only needed for test. Added it as a new dep with test scope.Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.