Skip to content

Conversation

@codope
Copy link
Member

@codope codope commented Jan 12, 2022

What is the purpose of the pull request

Fixes HUDI-2943

  • Add config to retry last pending clustering before writing to sink
  • If the config set to true and inline clustering enabled, then complete the pending clustering before writing to sink.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

@nsivabalan
Copy link
Contributor

Can you check CI failures please.

Add unit test

Fix the test and address review comments

Remove unused import

Rebase and fix test
@codope codope force-pushed the HUDI-2943-clustering-deltastreamer branch from 1e09793 to 38433f8 Compare January 28, 2022 13:24
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan merged commit e78b2f1 into apache:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants