[HUDI-3007] Fix issues in HoodieRepairTool#4564
Merged
yihua merged 8 commits intoapache:masterfrom Jan 12, 2022
Merged
Conversation
nsivabalan
approved these changes
Jan 11, 2022
Contributor
nsivabalan
left a comment
There was a problem hiding this comment.
Few minor comments. I will merge this in and pull it into 0.10.1. You can address any feedback in a follow up patch.
Contributor
|
@yihua : looks like there are some test failures in Repair tool tests. Can you check them out please. |
Collaborator
Contributor
Author
It's all good now. I'm going to merge the PR. |
nsivabalan
pushed a commit
that referenced
this pull request
Jan 13, 2022
5 tasks
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR fixes a few issues in HoodieRepairTool and adds unit and functional tests to guarantee the functionality of the repair utility.
Brief change log
UNDOmode to get the correct list of files to restore.HoodieEngineContextinstance to generalize parallelized operations instead of hardcodingJavaSparkContextand spark logic.deleteFiles().Verify this pull request
This change adds new tests:
TestRepairUtil,TestHoodieRepairTool, andTestFSUtils.HoodieRepairToollocally.Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.