[HUDI-3184] hudi-flink support timestamp-micros#4548
Merged
danny0405 merged 9 commits intoapache:masterfrom Jan 12, 2022
Merged
[HUDI-3184] hudi-flink support timestamp-micros#4548danny0405 merged 9 commits intoapache:masterfrom
danny0405 merged 9 commits intoapache:masterfrom
Conversation
danny0405
reviewed
Jan 10, 2022
| switch (unit) { | ||
| case MILLIS: | ||
| chronoUnit = ChronoUnit.MILLIS; | ||
| break; |
Contributor
There was a problem hiding this comment.
I guess the chronoUnit can be a class member variable right ?
And, we should also fix the non-utc timezone code path.
| case TIMESTAMP_WITHOUT_TIME_ZONE: | ||
| return AvroToRowDataConverters::convertToTimestamp; | ||
| return avroObject -> convertToTimestamp(avroObject, (TimestampType) type); | ||
| case CHAR: |
Contributor
There was a problem hiding this comment.
We can also instantiate the chronoUnit first based on the type precision.
| + ", it only supports precision less than 6."); | ||
| } | ||
| return TimestampData.fromLocalDateTime( | ||
| LocalDateTime.ofInstant(Instant.ofEpochSecond(0).plus(timestamp, chronoUnit), ZoneId.systemDefault())); |
Contributor
There was a problem hiding this comment.
We should utc timezone here:
TimestampData.fromInstant(Instant.EPOCH.plus(timestamp, chronoUnit))| final ZoneOffset offset = ZoneOffset.systemDefault().getRules().getOffset(LocalDateTime.now()); | ||
| if (schema.getLogicalType() instanceof LogicalTypes.TimestampMillis) { | ||
| return now.toInstant(offset).toEpochMilli(); | ||
| } else if (schema.getLogicalType() instanceof LogicalTypes.TimestampMicros) { |
Contributor
There was a problem hiding this comment.
We can instantiate two converters like this:
TimestampType timestampType = (TimestampType) type;
if (timestampType.getPrecision() <= 3) {
converter =
new RowDataToAvroConverter() {
private static final long serialVersionUID = 1L;
@Override
public Object convert(Schema schema, Object object) {
return ((TimestampData) object).toInstant().toEpochMilli();
}
};
} else if (timestampType.getPrecision() <= 6) {
converter =
new RowDataToAvroConverter() {
private static final long serialVersionUID = 1L;
@Override
public Object convert(Schema schema, Object object) {
return ChronoUnit.MICROS.between(Instant.EPOCH, ((TimestampData) object).toInstant());
}
};
} else {
throw new UnsupportedOperationException("Unsupported type: " + type);
}| } | ||
|
|
||
| private static TimestampData convertToTimestamp(long timestamp, TimestampType logicalType) { | ||
| final int precision = logicalType.getPrecision(); |
Contributor
There was a problem hiding this comment.
Same as RowDataToAvroConverters, instantiate two converters here.
| switch (unit) { | ||
| case MILLIS: | ||
| return TimeUnit.SECONDS.toMillis(now.toEpochSecond(offset)) | ||
| + now.toInstant(offset).getLong(ChronoField.MILLI_OF_SECOND); |
Contributor
There was a problem hiding this comment.
Can we convert the TimestampData to Instant first then to the long then ? It is more concise i think.
Contributor
|
Thanks for the contribution, i have left some comments ~ |
danny0405
reviewed
Jan 11, 2022
| private static TimestampData int64ToTimestamp( | ||
| boolean utcTimestamp, | ||
| long millionsOfDay, | ||
| ChronoUnit unit) { |
Contributor
There was a problem hiding this comment.
millionsOfDay => interval
Collaborator
5 tasks
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Jan 26, 2022
* support both avro and parquet code path * string rowdata conversion is also supported
liusenhua
pushed a commit
to liusenhua/hudi
that referenced
this pull request
Mar 1, 2022
* support both avro and parquet code path * string rowdata conversion is also supported
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
* support both avro and parquet code path * string rowdata conversion is also supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
hudi-flink module support timestamp-micros. (HUDI-3184)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.