Skip to content

[HUDI-3185] HoodieConfig#getBoolean should return false when default …#4536

Merged
nsivabalan merged 1 commit intoapache:masterfrom
codope:HUDI-3185-config-null
Jan 7, 2022
Merged

[HUDI-3185] HoodieConfig#getBoolean should return false when default …#4536
nsivabalan merged 1 commit intoapache:masterfrom
codope:HUDI-3185-config-null

Conversation

@codope
Copy link
Copy Markdown
Member

@codope codope commented Jan 7, 2022

…not set

What is the purpose of the pull request

If user has not set a config and setDefaults() is not called before checking the config, then getBoolean (or getString, getInt) returns null which can cause NPE. At least, for boolean configs we should return default value if it is provided in config declaration. This does not change the behavior. For string or int configs, we should let it return null because there can be checks in the code based on null or empty. In that case we don't want to set some value.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan nsivabalan added the priority:critical Production degraded; pipelines stalled label Jan 7, 2022
@codope codope force-pushed the HUDI-3185-config-null branch from d7f3efb to 70807b8 Compare January 7, 2022 16:12
@hudi-bot
Copy link
Copy Markdown
Collaborator

hudi-bot commented Jan 7, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan merged commit 518488c into apache:master Jan 7, 2022
nsivabalan pushed a commit that referenced this pull request Jan 10, 2022
@vinishjail97 vinishjail97 mentioned this pull request Jan 24, 2022
5 tasks
vingov pushed a commit to vingov/hudi that referenced this pull request Jan 26, 2022
liusenhua pushed a commit to liusenhua/hudi that referenced this pull request Mar 1, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:critical Production degraded; pipelines stalled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants